fix(udp): propagate error on apple_fast #2073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With quinn-rs#2017, the concrete `send` implementations per platform are supposed to propagate `io::Error`s. Those errors are then eiter logged and dropped in `UdpSocketState::send` or further propagated in `UdpSocketState::try_send`. The `fast_apple` `send` implementation added in quinn-rs#1993 does not follow this pattern. This commit adjusts the `fast_apple` implementation accordingly.
|
FWIW, Rust 1.83 (released yesterday) stabilised new |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Dec 11, 2024
…chain-reviewers `quinn-udp` `v0.5.8` contains an intermediary fix for Bug 1916558, see quinn-rs/quinn#2071. In addition `quinn-udp` `v0.5.8` Includes the following bugfixes: - quinn-rs/quinn#2072 - quinn-rs/quinn#2073 - quinn-rs/quinn#2074 - quinn-rs/quinn#2050 - quinn-rs/quinn#2047 Differential Revision: https://phabricator.services.mozilla.com/D231505
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Dec 12, 2024
…chain-reviewers `quinn-udp` `v0.5.8` contains an intermediary fix for Bug 1916558, see quinn-rs/quinn#2071. In addition `quinn-udp` `v0.5.8` Includes the following bugfixes: - quinn-rs/quinn#2072 - quinn-rs/quinn#2073 - quinn-rs/quinn#2074 - quinn-rs/quinn#2050 - quinn-rs/quinn#2047 Differential Revision: https://phabricator.services.mozilla.com/D231505
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Dec 13, 2024
…chain-reviewers `quinn-udp` `v0.5.8` contains an intermediary fix for Bug 1916558, see quinn-rs/quinn#2071. In addition `quinn-udp` `v0.5.8` Includes the following bugfixes: - quinn-rs/quinn#2072 - quinn-rs/quinn#2073 - quinn-rs/quinn#2074 - quinn-rs/quinn#2050 - quinn-rs/quinn#2047 Differential Revision: https://phabricator.services.mozilla.com/D231505 UltraBlame original commit: a8cd98601fdff821fe9cc516ddb61f54c104fb58
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Dec 13, 2024
…chain-reviewers `quinn-udp` `v0.5.8` contains an intermediary fix for Bug 1916558, see quinn-rs/quinn#2071. In addition `quinn-udp` `v0.5.8` Includes the following bugfixes: - quinn-rs/quinn#2072 - quinn-rs/quinn#2073 - quinn-rs/quinn#2074 - quinn-rs/quinn#2050 - quinn-rs/quinn#2047 Differential Revision: https://phabricator.services.mozilla.com/D231505 UltraBlame original commit: a8cd98601fdff821fe9cc516ddb61f54c104fb58
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Dec 13, 2024
…chain-reviewers `quinn-udp` `v0.5.8` contains an intermediary fix for Bug 1916558, see quinn-rs/quinn#2071. In addition `quinn-udp` `v0.5.8` Includes the following bugfixes: - quinn-rs/quinn#2072 - quinn-rs/quinn#2073 - quinn-rs/quinn#2074 - quinn-rs/quinn#2050 - quinn-rs/quinn#2047 Differential Revision: https://phabricator.services.mozilla.com/D231505 UltraBlame original commit: a8cd98601fdff821fe9cc516ddb61f54c104fb58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #2017, the concrete
sendimplementations per platform are supposed to propagateio::Errors. Those errors are then eiter logged and dropped inUdpSocketState::sendor further propagated inUdpSocketState::try_send.The
fast_applesendimplementation added in#1993 does not follow this pattern.
This commit adjusts the
fast_appleimplementation accordingly.