Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(udp): retry on ErrorKind::Interrupted #2074

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

mxinden
Copy link
Collaborator

@mxinden mxinden commented Nov 29, 2024

On Linux and Android, quinn-udp will retry a send on ErrorKind::Interrupted:

quinn/quinn-udp/src/unix.rs

Lines 305 to 312 in e318cc4

loop {
let n = unsafe { libc::sendmsg(io.as_raw_fd(), &msg_hdr, 0) };
if n == -1 {
let e = io::Error::last_os_error();
match e.kind() {
io::ErrorKind::Interrupted => {
// Retry the transmission
continue;

Do the same on all other unix platforms.

quinn-udp/src/unix.rs Outdated Show resolved Hide resolved
@mxinden mxinden marked this pull request as ready for review November 29, 2024 15:32
@mxinden mxinden requested review from djc and Ralith as code owners November 29, 2024 15:32
Copy link
Collaborator

@Ralith Ralith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

quinn-udp/src/unix.rs Outdated Show resolved Hide resolved
quinn-udp/src/unix.rs Show resolved Hide resolved
@djc djc enabled auto-merge December 2, 2024 09:29
@djc
Copy link
Member

djc commented Dec 2, 2024

Just needs rebasing!

On Linux and Android, `quinn-udp` will retry a send on `ErrorKind::Interrupted`:

https://github.com/quinn-rs/quinn/blob/e318cc4a80436fd9fa19c02886d682c49efca185/quinn-udp/src/unix.rs#L305-L312

Do the same on all other unix platforms.
@djc djc added this pull request to the merge queue Dec 3, 2024
Merged via the queue into quinn-rs:main with commit 31a0440 Dec 3, 2024
18 checks passed
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Dec 11, 2024
…chain-reviewers

`quinn-udp` `v0.5.8` contains an intermediary fix for Bug 1916558, see
quinn-rs/quinn#2071.

In addition `quinn-udp` `v0.5.8` Includes the following bugfixes:

- quinn-rs/quinn#2072
- quinn-rs/quinn#2073
- quinn-rs/quinn#2074
- quinn-rs/quinn#2050
- quinn-rs/quinn#2047

Differential Revision: https://phabricator.services.mozilla.com/D231505
i3roly pushed a commit to i3roly/firefox-dynasty that referenced this pull request Dec 12, 2024
…chain-reviewers

`quinn-udp` `v0.5.8` contains an intermediary fix for Bug 1916558, see
quinn-rs/quinn#2071.

In addition `quinn-udp` `v0.5.8` Includes the following bugfixes:

- quinn-rs/quinn#2072
- quinn-rs/quinn#2073
- quinn-rs/quinn#2074
- quinn-rs/quinn#2050
- quinn-rs/quinn#2047

Differential Revision: https://phabricator.services.mozilla.com/D231505
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Dec 13, 2024
…chain-reviewers

`quinn-udp` `v0.5.8` contains an intermediary fix for Bug 1916558, see
quinn-rs/quinn#2071.

In addition `quinn-udp` `v0.5.8` Includes the following bugfixes:

- quinn-rs/quinn#2072
- quinn-rs/quinn#2073
- quinn-rs/quinn#2074
- quinn-rs/quinn#2050
- quinn-rs/quinn#2047

Differential Revision: https://phabricator.services.mozilla.com/D231505

UltraBlame original commit: a8cd98601fdff821fe9cc516ddb61f54c104fb58
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Dec 13, 2024
…chain-reviewers

`quinn-udp` `v0.5.8` contains an intermediary fix for Bug 1916558, see
quinn-rs/quinn#2071.

In addition `quinn-udp` `v0.5.8` Includes the following bugfixes:

- quinn-rs/quinn#2072
- quinn-rs/quinn#2073
- quinn-rs/quinn#2074
- quinn-rs/quinn#2050
- quinn-rs/quinn#2047

Differential Revision: https://phabricator.services.mozilla.com/D231505

UltraBlame original commit: a8cd98601fdff821fe9cc516ddb61f54c104fb58
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Dec 13, 2024
…chain-reviewers

`quinn-udp` `v0.5.8` contains an intermediary fix for Bug 1916558, see
quinn-rs/quinn#2071.

In addition `quinn-udp` `v0.5.8` Includes the following bugfixes:

- quinn-rs/quinn#2072
- quinn-rs/quinn#2073
- quinn-rs/quinn#2074
- quinn-rs/quinn#2050
- quinn-rs/quinn#2047

Differential Revision: https://phabricator.services.mozilla.com/D231505

UltraBlame original commit: a8cd98601fdff821fe9cc516ddb61f54c104fb58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants