refactor(udp): remove unnecessary return

[mxinden]

No need to return Ok(()) early, given the final return Ok(()) at the end of the function. Makes it consistent with other send implementations. Makes it consistent with early returns being errors only.

Follow-up to #2074 (comment). I have not yet been able to come up with a better refactoring.

[Ralith]

I don't think this is equivalent. If sendmsg fails with EMSGSIZE, then with this change the loop will continue rather than bailing out with success.

[mxinden]

If it fails with EMSGSIZE it will exit the match e.kind() closure:

quinn/quinn-udp/src/unix.rs

Line 309 in 6716b5a

match e.kind() {

Then exit the if n == -1 closure:

quinn/quinn-udp/src/unix.rs

Line 307 in 6716b5a

if n == -1 {

But before looping again:

quinn/quinn-udp/src/unix.rs

Line 305 in 6716b5a

loop {

It would return Ok(()) at the end of the loop iteration:

quinn/quinn-udp/src/unix.rs

Line 349 in 6716b5a

return Ok(());

@Ralith am I missing something?

[Ralith]

Ah, you're right, miscounted the brackets. Thanks!