Hide skipped tests

[justinbmeyer]

I'd like to propose a hideskipped tests url parameter that QUnit understands. We run our tests with saucelabs which has videos of the tests running. Without being able to hide skipped tests, we are unable to see which test failed.

This would work just like hidepassed. Both should be able to be active at the same time.

Let me know if this sounds reasonable and I can probably submit a pull request. Thanks!

[rwjblue]

👍 - This would be very helpful for the various refactoring efforts that we have had in glimmer-vm.

[rwjblue]

An alternative here would be to always show failed tests above the rest (not sure if that breaks other constraints though).

[trentmwillis]

Sounds reasonable to me. However, if we want to add this option to the UI (as we do with hidepassed), then we'll need to do some refactoring as I want to avoid cluttering the UI too much. We'd likely want a multi-select dropdown type feature.

[Krinkle]

Per #1315, I think hiding skipped tests and doing so by default in QUnit has potential to hide problems or make it more difficult to investigate what's going on as they would be missing by default, and thus not be there for new contributors to a code base. I can see that adding friction without much gained value.

The list of tests that have been run or considered to run is imho expected to be complete.

I do note that currently when selecting "Hide passed tests", we leave skipped tests behind and still visible. I'd be open to changing that to consider skipped ones as passing for the purpose of that option. Would that help?

[rwjblue]

I do note that currently when selecting "Hide passed tests", we leave skipped tests behind and still visible. I'd be open to changing that to consider skipped ones as passing for the purpose of that option. Would that help?

Seems like a nice improvement to me...

[Krinkle]

Thanks! I'll circle back to this over the coming weeks. Got a few other issues and PRs to handle first but patch welcome in the meanwhile :)