Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML Reporter: Hide skipped tests when hidepassed is set #1459

Merged
merged 1 commit into from
Jul 20, 2020
Merged

HTML Reporter: Hide skipped tests when hidepassed is set #1459

merged 1 commit into from
Jul 20, 2020

Conversation

raycohen
Copy link
Member

@raycohen raycohen commented Jul 9, 2020

Fixes #1208

Also adds the test file with the for hidepassed to the list of tests to be run.

I don't think there is test coverage on my changes to the toolbarChanged method.

@jsf-clabot
Copy link

jsf-clabot commented Jul 9, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@rwjblue
Copy link
Contributor

rwjblue commented Jul 13, 2020

Nice, thanks for picking this up @raycohen!

@Krinkle Krinkle self-assigned this Jul 13, 2020
@Krinkle Krinkle merged commit 2f8024b into qunitjs:master Jul 20, 2020
@raycohen raycohen deleted the hide-skipped-tests branch July 20, 2020 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Krinkle Krinkle

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide skipped tests
4 participants
@raycohen @jsf-clabot @rwjblue @Krinkle