Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native macOS Security support #1080

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Add native macOS Security support #1080

wants to merge 8 commits into from

Conversation

tresf
Copy link
Contributor

@tresf tresf commented Jan 20, 2023

Goal

Create a MacCertificateInstaller similar to WindowsCertificateInstaller that leverages JNA and native system libraries for interacting with the computer certificate store.

Milestones

  • Add certificate (started)
  • Remove certificate
  • Verify certificate

Related #1076, #841

@tresf
Copy link
Contributor Author

tresf commented Nov 7, 2024

This has some improvements that -- I believe -- are unrelated to this task and would make the PR easier to review if they were split out (e.g. removeAppLauncher, removeStartupEntry). @Vzor- can you please split this PR into two PRs so that we can take advantage of the refactor?

With regards to the Mac security stuff, I think it's still a good idea to add this if the efforts are fruitful. I understand that merging the Mac security stuff does not close #1076, however I believe the approach of using MacOS native libraries to be more professional approach at installing our certificates.

@Vzor-
Copy link
Contributor

Vzor- commented Nov 11, 2024

This has some improvements that -- I believe -- are unrelated to this task and would make the PR easier to review if they were split out (e.g. removeAppLauncher, removeStartupEntry). @Vzor- can you please split this PR into two PRs so that we can take advantage of the refactor?

With regards to the Mac security stuff, I think it's still a good idea to add this if the efforts are fruitful. I understand that merging the Mac security stuff does not close #1076, however I believe the approach of using MacOS native libraries to be more professional approach at installing our certificates.

Agreed. It may take a couple of days until I'm back on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants