Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resolving check-dir when changing working-directory #615

Conversation

riccardoporreca
Copy link
Contributor

See run https://github.com/riccardoporreca/actions/runs/8194198667?check_suite_focus=true#step:6:169 reproducing the issue:

Warning: No files were found with the provided path: non-default-dir. No artifacts will be uploaded.

See the same case fixed when using proposed fix from the branch in run https://github.com/riccardoporreca/actions/runs/8194292727?check_suite_focus=true#step:6:155

Run actions/upload-artifact@main
with:
name: Linux-rrelease-results
path: /home/runner/work/actions/actions/test_pkg_subdir/non-default-dir
if-no-files-found: warn
[...]
With the provided path, there will be 54 files uploaded
Starting artifact upload

riccardoporreca and others added 2 commits September 5, 2022 20:05
* Should fix r-lib#614, at least for the typical case where `check-dir` is a relative path.
* `check-dir` is now resolved relative to the working directory, as absolute path to also make it independent of the working directory of subsequent steps were the resolved `check-dir-path` output is used.
@codecov-commenter
Copy link

Codecov Report

Merging #615 (8de5221) into v2-branch (4abf43a) will not change coverage.
The diff coverage is n/a.

❗ Current head 8de5221 differs from pull request most recent head eded980. Consider uploading reports for the commit eded980 to get more accurate results

@@             Coverage Diff             @@
##           v2-branch      #615   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
===========================================
  Files              2         2           
  Lines             10        10           
===========================================
  Hits              10        10           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gaborcsardi gaborcsardi merged commit 8e1f7b4 into r-lib:v2-branch Oct 19, 2022
@gaborcsardi
Copy link
Member

Thanks much!

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload of artifacts fails when working-directory is set for check-r-package
3 participants