WIP: custom row-metadata (#260) #328
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Happy to add some tests as well, something along the lines of the examples I supplied? |
krlmlr
reviewed
Jun 9, 2021
| rowid_width <- 0L | ||
| } else { | ||
| rowid_width <- get_cell_widths(rowid) |
There was a problem hiding this comment.
Should get_cell_widths(NULL) return 0L, to simplify this code?
| return(NULL) | ||
| } | ||
|
|
||
| if (is_false(has_row_id)) { |
There was a problem hiding this comment.
I wonder if this should be picked up by the methods instead?
|
This has conflicts now, unfortunately. |
|
Done in #550. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ad #260