Second try for rowids #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krlmlr
reviewed
May 10, 2022
There was a problem hiding this comment.
Can you please also add a paragraph in the description/details of the documentation, and perhaps also in https://pillar.r-lib.org/articles/extending.html ?
| ctl_new_rowid_pillar.tbl <- function(controller, x, width, has_row_id, ..., title = NULL) { | ||
| "!!!!DEBUG ctl_new_rowid_pillar.tbl(`v(width)`, `v(title)`)" | ||
|
|
||
| template <- names(ctl_new_pillar(controller, vector(), width, title = title)) |
added 3 commits
May 10, 2022 15:06
krlmlr
approved these changes
May 10, 2022
R/ctl_new_pillar.R
Outdated
| @@ -16,6 +16,8 @@ | |||
| #' implementation. | |||
| #' Override this method to completely change the appearance of the pillars. | |||
| #' Components are created with [new_pillar_component()] or [pillar_component()]. | |||
| #' In order to customize printing of row IDs, the generic a method can be | |||
There was a problem hiding this comment.
Suggested change
| #' In order to customize printing of row IDs, the generic a method can be | |
| #' In order to customize printing of row IDs, a method can be |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #260.