-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimize output noise when R has no NLS support #1662
Conversation
This issue has been annoying me for a while, so when I saw that the suggested changes were pretty minimal I just went ahead and fixed it locally. It was just a little extra work to prep it to share. Happy to make whatever changes are needed to get this issue resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! As well as the suggestion below, can you please also add a bullet to the top of NEWS.md
? It should briefly describe the change and end with (@yourname, #issuenumber)
.
Thanks! I ended up removing the test because I don't think it actually tests the case we really care about, and hence just gives a false sense of security. |
Fixes r-lib#1563. This is a minor addition to r-lib#1662.
Closes #1566
A pretty minor change to implement the suggested changes in #1566.
I made one additional design choice to emit a once-per-session warning when
local_reproducible_output
is run withoutNLS
, but I'm not sure exactly what the best behavior would be. I could see the argument either way - either as a good reminder that the tests may still fail on another system, or as an unfortunate state-dependent test result. I would have no problem removing it if reproducibility of test result warnings is the more important behavior.When run without
NLS
capability, the first test to check againstlocal_reproducible_output
will emit a warning: