Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement changes for Swift 4.2 and 5.0 with Xcode 10.2 #55

Merged
merged 5 commits into from
Mar 27, 2019
Merged

Implement changes for Swift 4.2 and 5.0 with Xcode 10.2 #55

merged 5 commits into from
Mar 27, 2019

Conversation

alanzeino
Copy link
Contributor

This resolves #54. I also added the Swift 5 changes that are needed as well; those are gated by #if swift(5.0). Other changes should be backwards compatible with 4.2.x versions of Swift with Xcode 10.

ra1028
ra1028 requested changes Mar 23, 2019
View reviewed changes
Sources/Algorithm.swift Outdated Show resolved Hide resolved
Sources/Algorithm.swift Outdated Show resolved Hide resolved
Sources/Extensions/AppKitExtension.swift Outdated Show resolved Hide resolved
Sources/StagedChangeset.swift Outdated Show resolved Hide resolved
Sources/Algorithm.swift Show resolved Hide resolved
Sources/Algorithm.swift Show resolved Hide resolved
@ra1028
Copy link
Owner

ra1028 commented Mar 23, 2019

Hi @alanzeino
Sorry for my late reply.

Thanks for the nice contribution.
Please check my comments to your codes.
Especially about the impact on performance.

@robotive
Copy link

@alanzeino @ra1028 Hi all, this PR misses a small change to UIKitExtension.swift to support Swift 5. I've attached a patch if interested. Thanks.

0001-Adds-Swift-5-support-to-UIKitExtension.patch.txt

@jessesquires jessesquires mentioned this pull request Mar 25, 2019
Merged
7 tasks
@anlaital
Copy link

@ra1028 anything we can do to get this merged and a new release built? Xcode 10.2 is officially out now and DifferenceKit's latest release no longer compiles with it.

@Kaspik
Copy link
Contributor

Kaspik commented Mar 26, 2019

Fixed the PR feedback by @ra1028 , waiting for @alanzeino to merge the PR to update this one. https://github.com/alanzeino/DifferenceKit/pull/1

@parrots parrots mentioned this pull request Mar 26, 2019
Closed
@alanzeino
Merge pull request #1 from classdojo/xcode102
dfbac4a 
Update XCode 10.2 changes
@alanzeino
Copy link
Contributor Author

Thanks for that Kaspik. Should be ready for re–review now.

@Kaspik
Copy link
Contributor

Kaspik commented Mar 26, 2019

@ra1028 Let's get this moving! 🎉

@alanzeino
Copy link
Contributor Author

Branch needs a quick update, pushing now.

@wxhzzsf
Copy link

wxhzzsf commented Mar 27, 2019

@ra1028 please merge soon!

@ra1028
Copy link
Owner

ra1028 commented Mar 27, 2019

Nicely done @alanzeino @Kaspik
Thanks!

@ra1028 ra1028 merged commit 69f8cf4 into ra1028:master Mar 27, 2019
@ra1028 ra1028 mentioned this pull request Mar 27, 2019
Merged
@ra1028
Copy link
Owner

ra1028 commented Mar 27, 2019

Xcode10.2 compatible version has been released.

@alanzeino alanzeino deleted the xcode102 branch March 27, 2019 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parrots parrots parrots left review comments

@bofeizhu bofeizhu bofeizhu left review comments

@ra1028 ra1028 ra1028 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Algorithm.swift using hashValue needs to be updated to use new Hashable pattern
8 participants
@alanzeino @ra1028 @robotive @anlaital @Kaspik @wxhzzsf @parrots @bofeizhu