Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swift5 compatibility #58

Merged
merged 16 commits into from
Mar 27, 2019
Merged

Swift5 compatibility #58

merged 16 commits into from
Mar 27, 2019

Conversation

ra1028
Copy link
Owner

@ra1028 ra1028 commented Mar 27, 2019

CC: @alanzeino @Kaspik @BjornRuud

Kaspik
Kaspik approved these changes Mar 27, 2019
View reviewed changes
DifferenceKit.podspec
@@ -13,6 +13,7 @@ Pod::Spec.new do |spec|
spec.license = { :type => 'MIT', :file => 'LICENSE' }
spec.requires_arc = true
spec.default_subspecs = 'Core', 'UIKitExtension'
spec.swift_version = "4.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be 5.0?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably shouldn't 😂

Copy link
Owner Author

@ra1028 ra1028 Mar 27, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kaspik
DifferenceKit should supports both Swift4.2 and 5.0.
Xcode10.2 is able to build sources that are written in either Swift 5 or Swift 4.2.

@ra1028 ra1028 merged commit a62a9ed into master Mar 27, 2019
@ra1028 ra1028 deleted the swift5-compatibility branch March 27, 2019 14:33
@alanzeino
Copy link
Contributor

👍

@Z-JaDe
Copy link

Z-JaDe commented Apr 22, 2019

spec.swift_versions = ["4.2", "5.0"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kaspik Kaspik Kaspik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ra1028 @alanzeino @Z-JaDe @Kaspik