Feat(Gmx): Gmx swap #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cddb762 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jimobrien
approved these changes
Sep 21, 2023
jimobrien
reviewed
Sep 21, 2023
| return data.map((token) => token.id) | ||
| } else { | ||
| console.error(`Request failed with status code: ${response.status}`) | ||
| return [] |
There was a problem hiding this comment.
Should we fail over to a static list of the majors?
There was a problem hiding this comment.
Great idea - I've added sensible defaults to a static list equivalent to what the API currently returns.
jimobrien
reviewed
Sep 22, 2023
jimobrien
reviewed
Sep 22, 2023
jimobrien
reviewed
Sep 22, 2023
jimobrien
reviewed
Sep 22, 2023
| $abi: GMX_SWAPV2_ABI, | ||
| data: { | ||
| $some: { | ||
| $abi: GMX_SWAPV2_ABI, |
jimobrien
approved these changes
Sep 22, 2023
Quazia
added a commit
that referenced
this pull request
Feb 16, 2024
Feat(filter): add equal operator
mmackz
added a commit
that referenced
this pull request
Mar 8, 2024
* appky patch * change url for testing * update url * setup action * setup actions for testing * Testing (#28) * appky patch * change url for testing * update url * setup action * setup actions for testing * update action * simulate new plugin * Testing (#29) * appky patch * change url for testing * update url * setup action * setup actions for testing * simulate new plugin * update details test * Testing (#30) * appky patch * change url for testing * update url * setup action * setup actions for testing * simulate new plugin * update details test * add to existing package test * Testing (#31) * appky patch * change url for testing * update url * setup action * setup actions for testing * simulate new plugin * update details test * add to existing package test * non-config changes test * Testing (#32) * appky patch * change url for testing * update url * setup action * setup actions for testing * simulate new plugin * update details test * add to existing package test * non-config changes test * fail test * image too big * invalid image url * invalid appling * add plugin without config * add valid details * log * re-add details * valid details * Fail Testing (#33) * appky patch * change url for testing * update url * setup action * setup actions for testing * simulate new plugin * update details test * add to existing package test * non-config changes test * fail test * image too big * invalid image url * invalid appling * add plugin without config * add valid details * log * re-add details * valid details * invalid to new * last test * fix details * Testing (#34) * appky patch * change url for testing * update url * setup action * setup actions for testing * simulate new plugin * update details test * add to existing package test * non-config changes test * fail test * image too big * invalid image url * invalid appling * add plugin without config * add valid details * log * re-add details * valid details * invalid to new * last test * fix details * update icon * Mmackz/plugin details config (#36) * feat: add plugin details to db on pr * refactor(builder): use required params for mint/burn * refactor: use different logic for fetching updated config files * refactor: change name of action * fix: fetch origin * docs: add comments * feat: allow for multiple tasks * tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is blocked by rabbitholegg/questdk#14