Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter hotfix 9 21 23 #14

Merged
merged 3 commits into from
Sep 22, 2023
Merged

Filter hotfix 9 21 23 #14

merged 3 commits into from
Sep 22, 2023

Conversation

Quazia
Copy link
Member

@Quazia Quazia commented Sep 22, 2023

When using some, sometimes the elements that we're filtering on don't apply to all elements. This handles that edge case.

@changeset-bot
Copy link

changeset-bot bot commented Sep 22, 2023

🦋 Changeset detected

Latest commit: fea06f5

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

Size Change: +33 B (0%)

Total Size: 22.2 kB

Filename Size Change
dist/cjs/filter/filters.js 1.2 kB +14 B (+1%)
dist/esm/filter/filters.js 1.43 kB +19 B (+1%)
ℹ️ View Unchanged
Filename Size
dist/cjs/abi/erc20-quest.js 1.13 kB
dist/cjs/abi/erc20.js 578 B
dist/cjs/abi/quest-factory.js 2.08 kB
dist/cjs/actions/index.js 212 B
dist/cjs/actions/types.js 219 B
dist/cjs/constants.js 342 B
dist/cjs/errors/base.js 734 B
dist/cjs/errors/plugin.js 229 B
dist/cjs/errors/quest.js 331 B
dist/cjs/errors/utils.js 257 B
dist/cjs/errors/version.js 155 B
dist/cjs/filter/index.js 374 B
dist/cjs/filter/operators.js 367 B
dist/cjs/filter/types.js 124 B
dist/cjs/index.js 700 B
dist/cjs/quests/approveIfNeeded.js 525 B
dist/cjs/quests/constants.js 294 B
dist/cjs/quests/deployQuest.js 573 B
dist/cjs/quests/index.js 356 B
dist/cjs/quests/types.js 124 B
dist/cjs/utils/chains.js 375 B
dist/cjs/utils/compressJson.js 255 B
dist/cjs/utils/index.js 280 B
dist/esm/abi/erc20-quest.js 1.07 kB
dist/esm/abi/erc20.js 522 B
dist/esm/abi/quest-factory.js 2.02 kB
dist/esm/actions/index.js 91 B
dist/esm/actions/types.js 169 B
dist/esm/constants.js 303 B
dist/esm/errors/base.js 678 B
dist/esm/errors/plugin.js 158 B
dist/esm/errors/quest.js 276 B
dist/esm/errors/utils.js 164 B
dist/esm/errors/version.js 90 B
dist/esm/filter/index.js 161 B
dist/esm/filter/operators.js 228 B
dist/esm/filter/types.js 64 B
dist/esm/index.js 340 B
dist/esm/quests/approveIfNeeded.js 688 B
dist/esm/quests/constants.js 310 B
dist/esm/quests/deployQuest.js 494 B
dist/esm/quests/index.js 175 B
dist/esm/quests/types.js 64 B
dist/esm/utils/chains.js 448 B
dist/esm/utils/compressJson.js 279 B
dist/esm/utils/index.js 133 B

compressed-size-action

continue
}

if (typeof filters[key] === 'object') {
if (!apply(context[key], filters[key])) return false
if (!(key in context)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch

@Quazia Quazia merged commit d646642 into main Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants