Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Messages with x-deaths from pre-3.5.1 versions cause queue crash on dead-lettering #152

Closed
michaelklishin opened this issue May 8, 2015 · 2 comments
Closed

Messages with x-deaths from pre-3.5.1 versions cause queue crash on dead-lettering #152

michaelklishin opened this issue May 8, 2015 · 2 comments
Assignees
@michaelklishin
Labels
bug effort-low
Milestone
3.5.2

Comments

@michaelklishin
Copy link
Member

#78 needs to handle existing messages with x-deaths. See this mailing list thread.
@michaelklishin michaelklishin self-assigned this May 8, 2015
@michaelklishin michaelklishin added this to the 3.5.2 milestone May 8, 2015
@michaelklishin
Copy link
Member Author

I think the right thing to do is to fold existing x-deaths by {queue, reason} pairs before trying to do anything with the counter.

@michaelklishin michaelklishin mentioned this issue May 9, 2015
Merged
michaelklishin added a commit to rabbitmq/rabbitmq-java-client that referenced this issue May 9, 2015
@michaelklishin
Test for rabbitmq/rabbitmq-server#152
94f594e
michaelklishin added a commit to rabbitmq/rabbitmq-java-client that referenced this issue May 11, 2015
@michaelklishin
Merge pull request #56 from rabbitmq/rabbitmq-server-152
5706325 
Test for rabbitmq/rabbitmq-server#152
@dumbbell
Copy link
Member

Since RabbitMQ 3.5.1.

@michaelklishin michaelklishin mentioned this issue May 17, 2015
Closed
@michaelklishin michaelklishin mentioned this issue Jun 4, 2015
Closed
@cressie176 cressie176 mentioned this issue Mar 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelklishin michaelklishin

Labels
bug effort-low
Projects
None yet
Milestone
3.5.2
Development

No branches or pull requests
2 participants
@michaelklishin @dumbbell