Support x-death event values from before #78 #153
Conversation
We group x-death header values before processing them
to make sure there's only one per {queue, reason}.
|
Test case: rabbitmq/rabbitmq-java-client#56. |
| [X] -> | ||
| maybe_append_to_event_group( | ||
| ensure_xdeath_event_count(X), Q, R, Acc); | ||
| [X|_] = Xs when is_list(Xs) -> |
There was a problem hiding this comment.
do you need to test for is_list here when you are matching already for a list?
|
@videlalvaro ready for another round. I'll re-format with Emacs once we agree on everything else. |
|
About the sort, I think lists:partition should take care of partitioning the list by duplicates, provided the list is sorted |
|
Also see the comment related to duplicated fun code in |
|
Sorting is not sufficient: we may have duplicates in the input that |
For O(1) lookup complexity.
| [{table, rabbit_misc:sort_field_table(Info1)} | Others]) | ||
| end. | ||
|
|
||
| ensure_xdeath_event_count({table, Info}, InitialVal) when InitialVal >= 1 -> |
There was a problem hiding this comment.
are there cases where InitialVal might be less than one? If yes, the caller will get an undef error
There was a problem hiding this comment.
No. If we have an event, the number of times it happened is >= 1.
There was a problem hiding this comment.
Then what's the point of having those InitialVal guards?
On Mon, May 11, 2015 at 12:03 PM Michael Klishin notifications@github.com
wrote:
In src/rabbit_dead_letter.erl
#153 (comment)
:end, rabbit_misc:set_table_value(Headers, <<"x-death">>, array,
[{table, rabbit_misc:sort_field_table(Info1)} | Others])[{table, rabbit_misc:sort_field_table(Info1)} | Others])- end.
+ensure_xdeath_event_count({table, Info}, InitialVal) when InitialVal >= 1 ->
No. If we have an event, the number of times it happened is >= 1.
—
Reply to this email directly or view it on GitHub
https://github.com/rabbitmq/rabbitmq-server/pull/153/files#r30026279.
|
Added some comments, after those, I think just the indentation ones remain |
Support x-death event values from before #78
We group x-death header values before processing them
to make sure there's only one per {queue, reason}.
Fixes #152.