Let CI actually fail (#212)

* Let CI actually fail Resolves #211 * Make warnings errors * We need to be more specific * Swap assertEquals for assertEqual
ractf · Oct 23, 2021 · 1c68ff2 · 1c68ff2
1 parent 21173e2
commit 1c68ff2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/Makefile b/Makefile
@@ -17,7 +17,7 @@ test: migrate
 
 coverage: migrate
 	pytest --cov=. --cov-report=xml src && \
-	coverage html && \
+	coverage html
 	which xdg-open && \
 	xdg-open htmlcov/index.html || true
 

diff --git a/src/challenge/tests/test_views.py b/src/challenge/tests/test_views.py
@@ -452,7 +452,7 @@ def test_create_challenge_metadata_saves(self):
             format="json",
         )
         response = self.client.get(reverse("challenges-detail", kwargs={"pk": self.challenge1.pk}))
-        self.assertEquals(response.data["challenge_metadata"], metadata)
+        self.assertEqual(response.data["challenge_metadata"], metadata)
 
 
 class FlagCheckViewTestCase(ChallengeSetupMixin, APITestCase):