Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let CI actually fail #212

Merged
merged 4 commits into from
Oct 23, 2021
Merged

Let CI actually fail #212

merged 4 commits into from
Oct 23, 2021

Conversation

thebeanogamer
Copy link
Member

Resolves #211

RACTFBot
RACTFBot approved these changes Oct 23, 2021
View reviewed changes
Copy link
Member

@RACTFBot RACTFBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Auto-approved due to hotfix/ branch.

@thebeanogamer thebeanogamer requested a review from 0xAda October 23, 2021 14:55
@codecov
Copy link

codecov bot commented Oct 23, 2021 •
edited
Loading

Codecov Report

Merging #212 (d69b333) into master (fd3b8fe) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #212   +/-   ##
=======================================
  Coverage   94.35%   94.35%           
=======================================
  Files         107      107           
  Lines        4679     4679           
  Branches      269      269           
=======================================
  Hits         4415     4415           
  Misses        221      221           
  Partials       43       43
Impacted Files Coverage Δ
src/challenge/tests/test_views.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd3b8fe...d69b333. Read the comment docs.

@thebeanogamer thebeanogamer enabled auto-merge (squash) October 23, 2021 15:09
0xAda
0xAda approved these changes Oct 23, 2021
View reviewed changes
Copy link
Contributor

@0xAda 0xAda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thebeanogamer thebeanogamer merged commit 5e8263a into master Oct 23, 2021
@thebeanogamer thebeanogamer deleted the hotfix/211 branch October 23, 2021 15:09
@thebeanogamer thebeanogamer mentioned this pull request Jan 30, 2022
Open
0xAda pushed a commit that referenced this pull request Sep 26, 2024
@thebeanogamer
Let CI actually fail (#212)
1c68ff2 
* Let CI actually fail
Resolves #211

* Make warnings errors

* We need to be more specific

* Swap assertEquals for assertEqual
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RACTFBot RACTFBot RACTFBot approved these changes

@0xAda 0xAda 0xAda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests in CI Always Pass
3 participants
@thebeanogamer @0xAda @RACTFBot