Fix #16433 - Use MOV opcode B8+ for MOV r64, <0x80000000 to 0xffffffff> #16572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please resolve the conflict, the tests has been moved to test/db |
radare
reviewed
Apr 13, 2020
libr/asm/p/asm_x86_nz.c
Outdated
| ((!(op->operands[0].type & OT_QWORD) && (op->operands[1].type & OT_QWORD) && | ||
| immediate < UT32_MAX) || | ||
| ((op->operands[0].type & OT_QWORD) && | ||
| (immediate <= ST32_MAX || immediate >= 0xffffffff80000000 /* -0x80000000 */)))) { |
There was a problem hiding this comment.
use LL suffix on those 64bit numbers, some compilers may complain
…0xffffffff> radareorg#16572 ##asm Detailed description I've confirmed radareorg#16433 (comment) (including the nasm rax -> eax bug) and thus this pr makes the x86_64 assembler use the MOV B8+ encoding (MOV r64, imm64) when the immediate is between 0x80000000 and 0xffffffff for both: Consistency with GNU assembler. It actually does seem to be the expected encoding. This does mean that mov eax, 0xffffffff and mov rax, 0xffffffff will have very different semantics.
|
i did it |
|
thanks! |
Emi1305
pushed a commit
to Emi1305/radare2
that referenced
this pull request
Jul 12, 2020
…0xffffffff> radareorg#16572 ##asm Detailed description I've confirmed radareorg#16433 (comment) (including the nasm rax -> eax bug) and thus this pr makes the x86_64 assembler use the MOV B8+ encoding (MOV r64, imm64) when the immediate is between 0x80000000 and 0xffffffff for both: Consistency with GNU assembler. It actually does seem to be the expected encoding. This does mean that mov eax, 0xffffffff and mov rax, 0xffffffff will have very different semantics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
I've confirmed #16433 (comment) (including the nasm
rax->eaxbug) and thus this pr makes the x86_64 assembler use the MOV B8+ encoding (MOV r64, imm64) when the immediate is between 0x80000000 and 0xffffffff for both:This does mean that
mov eax, 0xffffffffandmov rax, 0xffffffffwill have very different semantics.Test plan
GitHub Actions and AppVeyor are green.
Closing issues
Closes #16433.