Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #16433 - Use MOV opcode B8+ for MOV r64, <0x80000000 to 0xffffffff> #16572

Merged
merged 1 commit into from
Apr 13, 2020
Merged

Fix #16433 - Use MOV opcode B8+ for MOV r64, <0x80000000 to 0xffffffff> #16572

merged 1 commit into from
Apr 13, 2020

Commits on Apr 13, 2020

  1. Fix radareorg#16433 - Use MOV opcode B8+ for MOV r64, <0x80000000 to … 

    …0xffffffff> radareorg#16572 ##asm

Detailed description

I've confirmed radareorg#16433 (comment) (including the nasm rax -> eax bug) and thus this pr
makes the x86_64 assembler use the MOV B8+ encoding (MOV r64, imm64) when the immediate
is between 0x80000000 and 0xffffffff for both:

Consistency with GNU assembler.  It actually does seem to be the expected encoding.
This does mean that mov eax, 0xffffffff and mov rax, 0xffffffff will have very different semantics.
    @kazarmy @radare
    kazarmy authored and radare committed Apr 13, 2020
    Configuration menu
    Copy the full SHA
    fbbbc24 View commit details
    Browse the repository at this point in the history