-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: vitest typecheck
#245
Conversation
After experimenting with Vitest versions, we need at least I went with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, I had seen this issue before but hadn't taken the time to fix it.
I tested it in a codespace, and it seems to work fine now, thanks.
Even though type checking is still in beta (I think that was one of the reasons why it wasn't active), it would be worth validating it in the CI stage.
@yamcodes just one thing, fix the PR title for “fix: vitest |
Thanks, @MarlonPassos-git, I agree. Since we have If we’re wary to use this feature officially, let’s add a separate script in However, to keep things simple, I suggest testing both together. |
ae1b7e1
to
21f00ba
Compare
Fix Vitest `typecheck` by (1) updating Vitest (2) enabling `typecheck` (3) pointing typecheck to the tests tsconfig
21f00ba
to
d61e48d
Compare
This is great 😄 Thanks a lot, @yamcodes |
Tip
The owner of this PR can publish a preview release by commenting
/publish
in this PR. Afterwards, anyone can try it out by runningpnpm add radashi@pr<PR_NUMBER>
.Summary
Fix Vitest
typecheck
by (1) updating Vitest (2) enablingtypecheck
(3) pointing typecheck to the tests tsconfigAll 3 avenues must be applied together, omitting one causes
type-d.ts
files either to pass blindly (false negatives) or not report at all.Related issue, if any:
Closes #244
For any code change,
Does this PR introduce a breaking change?
No
Bundle impact
src/array/merge.ts
Footnotes
Function size includes the
import
dependencies of the function. ↩