Support partial-completion for files #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemera
force-pushed
the
support-partial-completion-for-files
branch
2 times, most recently
from
97025d8 to
9d95160
Compare
clemera
force-pushed
the
support-partial-completion-for-files
branch
from
9d95160 to
e39d827
Compare
clemera
force-pushed
the
support-partial-completion-for-files
branch
from
21a4cb7 to
ac53066
Compare
clemera
force-pushed
the
support-partial-completion-for-files
branch
from
c3dd756 to
bee6873
Compare
clemera
force-pushed
the
support-partial-completion-for-files
branch
from
e99a07c to
a944d64
Compare
clemera
force-pushed
the
support-partial-completion-for-files
branch
from
a944d64 to
7181cb9
Compare
clemera
force-pushed
the
support-partial-completion-for-files
branch
from
07d3724 to
21ab656
Compare
This was referenced Jan 18, 2021
astoff
reviewed
Jan 19, 2021
| (is-tramp-path | ||
| ;; Check for tramp path, see | ||
| ;; `tramp-initial-file-name-regexp'. | ||
| (string-match-p "\\`/[^/:]+:[^/:]*:" path)) |
There was a problem hiding this comment.
FWIW, there is also file-remote-p
There was a problem hiding this comment.
Thanks, I thought this would only catch real remote paths and not /sudo:: for example I will switch to that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #385, possible partial completion candidates are shown when the directory of the input doesn't exist. This makes it fit nicely into the way Selectrum handles file completions, the query doesn't needs to be done later when refining, the querying and returning of possible candidates are all handled by the dynamic completion function.