Improve partial-style file completions #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemera
force-pushed
the
improve-partial-style-file-completions
branch
from
2890a70 to
e05e98e
Compare
clemera
force-pushed
the
improve-partial-style-file-completions
branch
from
c8a60b6 to
bb1ffb8
Compare
clemera
force-pushed
the
improve-partial-style-file-completions
branch
from
8157b46 to
80ad2ce
Compare
clemera
force-pushed
the
improve-partial-style-file-completions
branch
from
cfb319c to
044e537
Compare
clemera
force-pushed
the
improve-partial-style-file-completions
branch
2 times, most recently
from
2dec1ae to
f6c2400
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#390 introduced partial completions for the input path, afterwards one can continue to filter these using the configured filter function / completion-styles. In case one would like to use the partial-completion style on these results this still wouldn't work as reported by @mathrick in #82. To fix this I remapped the partial-style for the partial file completion case using
completion-styles-alist. This isn't nice but seems like the best way to handle partial-completion style for files from Selectrum side.