Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add file info extension (remove checksum extension) #934

Merged
merged 7 commits into from
Dec 16, 2020
Merged

Add file info extension (remove checksum extension) #934

merged 7 commits into from
Dec 16, 2020

Conversation

m-mohr
Copy link
Collaborator

@m-mohr m-mohr commented Dec 16, 2020

Related Issue(s): #879 #921

Proposed Changes:

  1. Add file info extension with 5 fields, see [Item] Asset size property (content length) #921
  2. Remove checksum extension (is now part of the file info extension)

cc for review: @geospatial-jeff @kylebarron @emmanuelmathot @vincentsarago

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.
  • This PR affects the STAC API spec, and I have opened issue/PR #XXX to track the change.

@m-mohr m-mohr added this to the 1.0.0-beta.3 milestone Dec 16, 2020
This was referenced Dec 16, 2020
Closed
Closed
Closed
Closed
@jisantuc jisantuc mentioned this pull request Dec 16, 2020
Open
jisantuc
jisantuc reviewed Dec 16, 2020
View reviewed changes
extensions/file/README.md Outdated Show resolved Hide resolved
extensions/file/README.md Outdated Show resolved Hide resolved
kylebarron
kylebarron approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@kylebarron kylebarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

extensions/file/README.md Outdated Show resolved Hide resolved
extensions/file/README.md Outdated Show resolved Hide resolved
@m-mohr @kylebarron
Apply suggestions from code review
7b7265f 
Co-authored-by: Kyle Barron <kylebarron2@gmail.com>
@m-mohr m-mohr linked an issue Dec 16, 2020 that may be closed by this pull request
[Item] Asset size property (content length) #921
Closed
cholmes
cholmes approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@cholmes cholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@m-mohr
Copy link
Collaborator Author

m-mohr commented Dec 16, 2020

Great. Merging for now, but let me know if you find additional things to change/improve/add. Happy to make further PRs.

@m-mohr m-mohr merged commit 06b48a3 into dev Dec 16, 2020
@m-mohr m-mohr deleted the file-ext branch December 16, 2020 18:02
@schwehr schwehr mentioned this pull request Apr 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylebarron kylebarron kylebarron approved these changes

@jisantuc jisantuc jisantuc approved these changes

@cholmes cholmes cholmes approved these changes

@matthewhanson matthewhanson Awaiting requested review from matthewhanson

Assignees
No one assigned
Labels
new extension
Projects
None yet
Milestone
1.0.0-RC.1
Development

Successfully merging this pull request may close these issues.

[Item] Asset size property (content length)
4 participants
@m-mohr @cholmes @jisantuc @kylebarron