Skip to content

Commit

Permalink
Revert "Update kubebuilder to the latest working version" (#7632)
Browse files Browse the repository at this point in the history
Reverts #7629

This was fixed as per the convo in
kubernetes-sigs/controller-runtime#2838. It
looks like the binaries weren't released for the version of Kubernetes
that we were using (they had up until 1.24 but we were using 1.23)

Fixes: #7630

---------

Signed-off-by: sk593 <shruthikumar@microsoft.com>
  • Loading branch information
sk593 committed May 28, 2024
1 parent f7ef3b2 commit 2b2b9d9
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions build/test.mk
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ RADIUS_CONTAINER_LOG_PATH ?=./dist/container_logs
REL_VERSION ?=latest
DOCKER_REGISTRY ?=ghcr.io/radius-project/dev
ENVTEST_ASSETS_DIR=$(shell pwd)/bin
K8S_VERSION=1.23.*
K8S_VERSION=1.30.*
ENV_SETUP=$(GOBIN)/setup-envtest$(BINARY_EXT)

# Use gotestsum if available, otherwise use go test. We want to enable testing with just 'make test'
Expand All @@ -49,7 +49,7 @@ test: test-get-envtools ## Runs unit tests, excluding kubernetes controller test
.PHONY: test-get-envtools
test-get-envtools:
@echo "$(ARROW) Installing Kubebuilder test tools..."
$(call go-install-tool,$(ENV_SETUP),sigs.k8s.io/controller-runtime/tools/setup-envtest@v0.0.0-20240521074430-fbb7d370bebc)
$(call go-install-tool,$(ENV_SETUP),sigs.k8s.io/controller-runtime/tools/setup-envtest@latest)
@echo "$(ARROW) Instructions:"
@echo "$(ARROW) Set environment variable KUBEBUILDER_ASSETS for tests."
@echo "$(ARROW) KUBEBUILDER_ASSETS=\"$(shell $(ENV_SETUP) use -p path ${K8S_VERSION} --arch amd64)\""
Expand Down

0 comments on commit 2b2b9d9

Please sign in to comment.