Revert "Update kubebuilder to the latest working version" #7632

sk593 · 2024-05-23T18:33:15Z

Reverts #7629

This was fixed as per the convo in kubernetes-sigs/controller-runtime#2838. It looks like the binaries weren't released for the version of Kubernetes that we were using (they had up until 1.24 but we were using 1.23)

Fixes: #7630

github-actions · 2024-05-23T18:41:54Z

Unit Tests

3 194 tests ±0 3 188 ✅ ±0 3m 53s ⏱️ -7s
259 suites ±0 6 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 25e5365. ± Comparison against base commit f7ef3b2.

♻️ This comment has been updated with latest results.

codecov · 2024-05-23T18:42:35Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.05%. Comparing base (f7ef3b2) to head (25e5365).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7632      +/-   ##
==========================================
- Coverage   61.07%   61.05%   -0.02%     
==========================================
  Files         517      517              
  Lines       26556    26556              
==========================================
- Hits        16218    16214       -4     
- Misses       8916     8918       +2     
- Partials     1422     1424       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rynowak · 2024-05-23T19:44:30Z

build/test.mk

@@ -49,7 +49,7 @@ test: test-get-envtools ## Runs unit tests, excluding kubernetes controller test
 .PHONY: test-get-envtools
 test-get-envtools:
 	@echo "$(ARROW) Installing Kubebuilder test tools..."
-	$(call go-install-tool,$(ENV_SETUP),sigs.k8s.io/controller-runtime/tools/setup-envtest@v0.0.0-20240521074430-fbb7d370bebc)
+	$(call go-install-tool,$(ENV_SETUP),sigs.k8s.io/controller-runtime/tools/setup-envtest@latest)


Do you want to update the Kubernetes version? or do that separately?

I think it makes sense to address them at the same time. I'll add that update to this PR

rynowak

Code change looks good!

rynowak · 2024-05-23T19:45:15Z

@sk593 - looks like your DCO signoff is missing, can you fix that and then I'll launch the functional tests?

radius-functional-tests · 2024-05-24T17:40:51Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	`6ea0171`
Unique ID	funceb388661d7
Image tag	pr-funceb388661d7

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funceb388661d7
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funceb388661d7
controller test image location: ghcr.io/radius-project/dev/controller:pr-funceb388661d7
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funceb388661d7
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting msgrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting ucp functional tests...
⌛ Starting shared functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting cli functional tests...
✅ msgrp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ samples functional tests succeeded
✅ ucp functional tests succeeded
✅ daprrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ cli functional tests succeeded
✅ shared functional tests succeeded

radius-functional-tests · 2024-05-25T09:43:32Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	`44b825d`
Unique ID	func22f71f18be
Image tag	pr-func22f71f18be

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func22f71f18be
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func22f71f18be
controller test image location: ghcr.io/radius-project/dev/controller:pr-func22f71f18be
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func22f71f18be
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting daprrp functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting cli functional tests...
⌛ Starting samples functional tests...
⌛ Starting shared functional tests...
✅ msgrp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ daprrp functional tests succeeded
✅ samples functional tests succeeded
❌ ucp functional test failed. Please check the logs for more details
❌ cli functional test cancelled. Please check the logs for more details
❌ shared functional test cancelled. Please check the logs for more details

rynowak

- looks great thanks!

rynowak · 2024-05-28T15:56:27Z

Looks like DCO is missing.

This reverts commit 4cacb58. Signed-off-by: sk593 <shruthikumar@microsoft.com>

Signed-off-by: sk593 <shruthikumar@microsoft.com>

sk593 · 2024-05-28T16:19:00Z

Looks like DCO is missing.

whoops, branch should be updated now

radius-functional-tests · 2024-05-28T16:19:42Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	`753bc09`
Unique ID	funccca5d54990
Image tag	pr-funccca5d54990

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funccca5d54990
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funccca5d54990
controller test image location: ghcr.io/radius-project/dev/controller:pr-funccca5d54990
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funccca5d54990
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting msgrp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting samples functional tests...
⌛ Starting cli functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting shared functional tests...
✅ msgrp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ samples functional tests succeeded
✅ cli functional tests succeeded
✅ daprrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ shared functional tests succeeded

radius-functional-tests · 2024-05-28T19:05:57Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	`25e5365`
Unique ID	func0640dc3a1a
Image tag	pr-func0640dc3a1a

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func0640dc3a1a
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func0640dc3a1a
controller test image location: ghcr.io/radius-project/dev/controller:pr-func0640dc3a1a
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func0640dc3a1a
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting cli functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting kubernetes functional tests...
✅ msgrp functional tests succeeded
✅ samples functional tests succeeded
✅ ucp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ daprrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ cli functional tests succeeded
✅ shared functional tests succeeded

sk593 requested review from a team as code owners May 23, 2024 18:33

sk593 had a problem deploying to functional-tests May 23, 2024 18:33 — with GitHub Actions Failure

sk593 marked this pull request as draft May 23, 2024 18:33

rynowak reviewed May 23, 2024

View reviewed changes

rynowak previously approved these changes May 23, 2024

View reviewed changes

sk593 force-pushed the revert-7629-update-kubebuilder branch from d72d107 to 7929cf6 Compare May 23, 2024 19:49

sk593 had a problem deploying to functional-tests May 23, 2024 19:49 — with GitHub Actions Failure

sk593 dismissed rynowak’s stale review via 6ea0171 May 24, 2024 17:20

sk593 temporarily deployed to functional-tests May 24, 2024 17:20 — with GitHub Actions Inactive

sk593 changed the title ~~[testing] Revert "Update kubebuilder to the latest working version"~~ Revert "Update kubebuilder to the latest working version" May 24, 2024

sk593 marked this pull request as ready for review May 24, 2024 17:40

ytimocin force-pushed the revert-7629-update-kubebuilder branch from 6ea0171 to 44b825d Compare May 25, 2024 09:42

ytimocin temporarily deployed to functional-tests May 25, 2024 09:42 — with GitHub Actions Inactive

rynowak previously approved these changes May 28, 2024

View reviewed changes

sk593 and others added 2 commits May 28, 2024 09:18

Revert "Update kubebuilder to the latest working version (#7629)"

217f645

This reverts commit 4cacb58. Signed-off-by: sk593 <shruthikumar@microsoft.com>

update kubernetes version

4b83181

Signed-off-by: sk593 <shruthikumar@microsoft.com>

sk593 dismissed rynowak’s stale review via 4b83181 May 28, 2024 16:18

sk593 force-pushed the revert-7629-update-kubebuilder branch from 44b825d to 4b83181 Compare May 28, 2024 16:18

sk593 had a problem deploying to functional-tests May 28, 2024 16:18 — with GitHub Actions Failure

Merge branch 'main' into revert-7629-update-kubebuilder

753bc09

sk593 temporarily deployed to functional-tests May 28, 2024 16:18 — with GitHub Actions Inactive

Merge branch 'main' into revert-7629-update-kubebuilder

267dc1b

sk593 had a problem deploying to functional-tests May 28, 2024 18:01 — with GitHub Actions Failure

Merge branch 'main' into revert-7629-update-kubebuilder

25e5365

sk593 temporarily deployed to functional-tests May 28, 2024 19:04 — with GitHub Actions Inactive

ytimocin approved these changes May 28, 2024

View reviewed changes

sk593 merged commit 2b2b9d9 into main May 28, 2024
19 checks passed

sk593 deleted the revert-7629-update-kubebuilder branch May 28, 2024 20:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revert "Update kubebuilder to the latest working version" #7632

Revert "Update kubebuilder to the latest working version" #7632

sk593 commented May 23, 2024 •

edited

Loading

github-actions bot commented May 23, 2024 •

edited

Loading

codecov bot commented May 23, 2024 •

edited

Loading

rynowak May 23, 2024

sk593 May 23, 2024

rynowak left a comment

rynowak commented May 23, 2024

radius-functional-tests bot commented May 24, 2024 •

edited

Loading

radius-functional-tests bot commented May 25, 2024 •

edited

Loading

rynowak left a comment

rynowak commented May 28, 2024

sk593 commented May 28, 2024

radius-functional-tests bot commented May 28, 2024 •

edited

Loading

radius-functional-tests bot commented May 28, 2024 •

edited

Loading

Revert "Update kubebuilder to the latest working version" #7632

Revert "Update kubebuilder to the latest working version" #7632

Conversation

sk593 commented May 23, 2024 • edited Loading

github-actions bot commented May 23, 2024 • edited Loading

Unit Tests

codecov bot commented May 23, 2024 • edited Loading

Codecov Report

rynowak May 23, 2024

Choose a reason for hiding this comment

sk593 May 23, 2024

Choose a reason for hiding this comment

rynowak left a comment

Choose a reason for hiding this comment

rynowak commented May 23, 2024

radius-functional-tests bot commented May 24, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented May 25, 2024 • edited Loading

Radius functional test overview

Test Status

rynowak left a comment

Choose a reason for hiding this comment

rynowak commented May 28, 2024

sk593 commented May 28, 2024

radius-functional-tests bot commented May 28, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented May 28, 2024 • edited Loading

Radius functional test overview

Test Status

sk593 commented May 23, 2024 •

edited

Loading

github-actions bot commented May 23, 2024 •

edited

Loading

codecov bot commented May 23, 2024 •

edited

Loading

radius-functional-tests bot commented May 24, 2024 •

edited

Loading

radius-functional-tests bot commented May 25, 2024 •

edited

Loading

radius-functional-tests bot commented May 28, 2024 •

edited

Loading

radius-functional-tests bot commented May 28, 2024 •

edited

Loading