Skip to content

Commit

Permalink
remove 0x1BE checksum test
Browse files Browse the repository at this point in the history
  • Loading branch information
gregjhogan committed May 14, 2020
1 parent 0bd06c9 commit 01bf740
Showing 1 changed file with 9 additions and 8 deletions.
17 changes: 9 additions & 8 deletions tests/safety/test_honda.py
Original file line number Diff line number Diff line change
Expand Up @@ -274,14 +274,15 @@ def _alt_brake_msg(self, brake):
self.__class__.cnt_brake += 1
return self.packer.make_can_msg_panda("BRAKE_MODULE", self.PT_BUS, values)

def test_alt_brake_rx_hook(self):
self.safety.set_honda_alt_brake_msg(1)
self.safety.set_controls_allowed(1)
to_push = self._alt_brake_msg(0)
self.assertTrue(self._rx(to_push))
to_push[0].RDLR = to_push[0].RDLR & 0xFFF0FFFF # invalidate checksum
self.assertFalse(self._rx(to_push))
self.assertFalse(self.safety.get_controls_allowed())
# TODO: add back in once alternative brake checksum/counter validation is added
# def test_alt_brake_rx_hook(self):
# self.safety.set_honda_alt_brake_msg(1)
# self.safety.set_controls_allowed(1)
# to_push = self._alt_brake_msg(0)
# self.assertTrue(self._rx(to_push))
# to_push[0].RDLR = to_push[0].RDLR & 0xFFF0FFFF # invalidate checksum
# self.assertFalse(self._rx(to_push))
# self.assertFalse(self.safety.get_controls_allowed())

def test_alt_disengage_on_brake(self):
self.safety.set_honda_alt_brake_msg(1)
Expand Down

0 comments on commit 01bf740

Please sign in to comment.