Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dump build command when --out is specified #1066

Closed
wants to merge 1 commit into from

Conversation

iloveitaly
Copy link
Contributor

the build command contains a lot of values which are generated from the nixpacks
build process. Without these dumped in the --out directory it's hard to debug
and replicate what's going on with a build.

I have not implemented tests, formatting, etc. Would like to get feedback before spending more time on this.

  • Tests are added/updated if needed
  • Docs are updated if needed

the build command contains a lot of values which are generated from the nixpacks
build process. Without these dumped in the --out directory it's hard to debug
and replicate what's going on with a build.
Copy link
Contributor

@coffee-cup coffee-cup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is interesting. Is the use case mainly for debugging what Nixpacks is doing? I wonder if we could instead of a verbose mode where the docker command is output in the logs. Would that solve the problem?

Copy link
Contributor

This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale The pull request is stale label Feb 20, 2024
@coffee-cup coffee-cup removed the stale The pull request is stale label Feb 20, 2024
Copy link
Contributor

github-actions bot commented Mar 2, 2024

This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale The pull request is stale label Mar 2, 2024
Copy link
Contributor

github-actions bot commented Mar 8, 2024

This pull request was closed for lack of activity. Feel free to reopen later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale The pull request is stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants