-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dump build command when --out is specified #1115
Conversation
the build command contains a lot of values which are generated from the nixpacks build process. Without these dumped in the --out directory it's hard to debug and replicate what's going on with a build.
This also fixes a listing error that I believe exists in master 70e0a6a |
This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days |
Friendly reminder on this pull request! Feel free to let me know if there are any updates needed here. |
This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days |
Friendly reminder about this pull request! Please let me know if there is anything else that needs to be addressed. |
This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days |
Just a friendly reminder on this pull request! Let me know if there are any updates or additional actions needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Sorry about such the long delay to get this merged
Follow-up from #1066
Yes. Primarily for debugging.
Without this, it's hard to actually recreate what nixpacks is doing when building a dockerfile to
iterate on the Dockerfile config locally.
Outputting the build command would be fine, but it seems better to me to persist the necessary commands to build the
entire docker container exactly like nixpacks does when --dump is used.