Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dump build command when --out is specified #1115

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

iloveitaly
Copy link
Contributor

Follow-up from #1066

Is the use case mainly for debugging what Nixpacks is doing? I wonder if we could instead of a verbose mode where the docker command is output in the logs. Would that solve the problem?

Yes. Primarily for debugging.

Without this, it's hard to actually recreate what nixpacks is doing when building a dockerfile to
iterate on the Dockerfile config locally.

Outputting the build command would be fine, but it seems better to me to persist the necessary commands to build the
entire docker container exactly like nixpacks does when --dump is used.

the build command contains a lot of values which are generated from the nixpacks
build process. Without these dumped in the --out directory it's hard to debug
and replicate what's going on with a build.
@iloveitaly
Copy link
Contributor Author

This also fixes a listing error that I believe exists in master 70e0a6a

Copy link
Contributor

This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale The pull request is stale label Jun 20, 2024
@iloveitaly
Copy link
Contributor Author

Friendly reminder on this pull request! Feel free to let me know if there are any updates needed here.

@github-actions github-actions bot removed the stale The pull request is stale label Jun 21, 2024
Copy link
Contributor

github-actions bot commented Jul 1, 2024

This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale The pull request is stale label Jul 1, 2024
@iloveitaly
Copy link
Contributor Author

Friendly reminder about this pull request! Please let me know if there is anything else that needs to be addressed.

@github-actions github-actions bot removed the stale The pull request is stale label Jul 5, 2024
Copy link
Contributor

This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale The pull request is stale label Jul 15, 2024
@iloveitaly
Copy link
Contributor Author

Just a friendly reminder on this pull request! Let me know if there are any updates or additional actions needed.

@github-actions github-actions bot removed the stale The pull request is stale label Jul 16, 2024
Copy link
Contributor

@coffee-cup coffee-cup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Sorry about such the long delay to get this merged

@coffee-cup coffee-cup added the release/patch Author patch release label Jul 16, 2024
@coffee-cup coffee-cup merged commit 9298f90 into railwayapp:main Jul 16, 2024
94 of 95 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/patch Author patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants