Add identifier range info #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to support microsoft/vscode-go#962 this exposes the start/end range of the identifiers for each declaration. In some case (particularly imports) the `ast.Ident` is `nil`, so the identifier range is possibly `nil` too.
|
Hey, so I wanted to follow up more on this feedback from microsoft/vscode-go#962
I tried to keep this change safe by only adding a new field to the JSON without changing the structure of existing fields. In my experience most tools parsing JSON will ignore fields they don't recognize, so this is fairly safe. While I factored the Does that help address your concerns? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support microsoft/vscode-go#962 this exposes the start/end range of
the identifiers for each declaration. In some case (particularly imports) the
ast.Identisnil, so the identifier range is possiblyniltoo.I've quickly checked the output of this on some Go files, but since it requires some more integration work on the vscode-go side, it's probably best to finish that before merging in case this patch needs any more work.