Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten Kubernetes version label #5036

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Conversation

s0nea
Copy link

@s0nea s0nea commented Jun 23, 2023

Shorten the Kubernetes version label from "Please select a Kubernetes version" to "Kubernetes Version" to fit better into the form.

Before After
Screenshot_2023-06-23_15-29-04 Screenshot_2023-06-23_15-52-26
Screenshot_2023-06-23_16-06-05 Screenshot_2023-06-23_15-55-04

Fixes: #4847

Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix linter warnings

Shorten the Kubernetes version label from "Please select a Kubernetes
version" to "Kubernetes Version" to fit better into the form.

Signed-off-by: Tatjana Dehler <tdehler@suse.com>
@s0nea
Copy link
Author

s0nea commented Jun 23, 2023

Please fix linter warnings

Done 🙂

@s0nea s0nea requested a review from jandubois June 23, 2023 17:02
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I would like to see a second approval from someone who actually knows about Vue, e.g. @rak-phillip

Copy link
Contributor

@rak-phillip rak-phillip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rak-phillip rak-phillip merged commit 261f2f9 into rancher-sandbox:main Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FirstRun dialog: shorten Kubernetes version label
3 participants