try() is not a variant of run() #5094
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will fail with a non-zero exit code when not successful, so there is no need to `assert_success` after calling `try` without `run`. And while it does capture the command output in $output, that is an implementation detail that tests should not rely on; they have to call `run try` to set $output and $status. Exiting with non-zero status was part of 431fa12 and outputting the command output back to stdout was implemented in d678dba. Signed-off-by: Jan Dubois <jan.dubois@suse.com>
|
Commit has been included in #5160. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will fail with a non-zero exit code when not successful, so there is no need to
assert_successafter callingtrywithoutrun. And while it does capture the command output in $output, that is an implementation detail that tests should not rely on; they have to callrun tryto set $output and $status.Exiting with non-zero status was part of 431fa12 and outputting the command output back to stdout was implemented in d678dba.
There are 2
assert_successlines inbats/tests/helpers/vm.bashthat are not removed here to avoid a merge conflict with #5090 which does already remove them.