-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assorted BATS fixes for Windows #5160
Conversation
Summary of failures:
On linux I just see I'll write up each failure in a separate box to avoid making them too large. |
switch-engines.bats -- There were errors at
but apparently these are expected |
|
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See failures in comments.
When using_windows_exe the path is converted to the windows path. Signed-off-by: Jan Dubois <jan.dubois@suse.com>
Signed-off-by: Jan Dubois <jan.dubois@suse.com>
Invoke the full command via `sh -c "..."` instead. Signed-off-by: Jan Dubois <jan.dubois@suse.com>
Signed-off-by: Jan Dubois <jan.dubois@suse.com>
Signed-off-by: Jan Dubois <jan.dubois@suse.com>
Remove `assert_success` calls because we don't invoke `try` via `run`. Signed-off-by: Jan Dubois <jan.dubois@suse.com>
It will fail with a non-zero exit code when not successful, so there is no need to `assert_success` after calling `try` without `run`. And while it does capture the command output in $output, that is an implementation detail that tests should not rely on; they have to call `run try` to set $output and $status. Exiting with non-zero status was part of 431fa12 and outputting the command output back to stdout was implemented in d678dba. Signed-off-by: Jan Dubois <jan.dubois@suse.com>
It has a different default on Windows (manual) than on Unix (rcfiles). Signed-off-by: Jan Dubois <jan.dubois@suse.com>
@ericpromislow PTAL With this PR only the |
I'm still seeing #5160 (comment) -- this is using the Windows 1.9.1 release in user-mode, and the latest change on this branch |
Same failure on k8s/enable-disable-k8s (again against the 1.9.1 release installed for me only) |
My command-line:
Only This was using this branch in a WSL session, with a 1.9.1 release installed for user only in Windows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some tests still fail. See my recent comments (2023-07-19 around 12 noon PDT)
Update using a newer CI build for RD fixed `containers/platforms.bats. The Still failing:
and I didn't run the traefik test which is known to fail |
While the directories also exist on the host, they will not exist in the WSL distro on Windows, so can't be created from there. Signed-off-by: Jan Dubois <jan.dubois@suse.com>
It allows us to properly verify that a service has restarted. This change does not fix the traefik test on Windows, but seems like a more robust way to make sure we are using the restarted cluster and not the original one. Signed-off-by: Jan Dubois <jan.dubois@suse.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The two tests that are known to fail are still failing, and I saw a few network-related flakes. Approving so we can get these changes into main
and make it easier to run win bats tests.
No description provided.