Create unit tests for BATS helper functions #5134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jandubois
force-pushed
the
bats-helpers
branch
8 times, most recently
from
e03d7a7
to
c6b3367
Compare
jandubois
force-pushed
the
bats-helpers
branch
4 times, most recently
from
f2f983f
to
ebb5709
Compare
IsaSih
requested changes
Jul 19, 2023
jandubois
commented
Jul 20, 2023
Unfortunately this breaks the current |
jandubois
commented
Jul 20, 2023
| @test 'json_string' { | ||
| run json_string foo\ bar\"baz\' | ||
| assert_success | ||
| assert_output "\"foo bar\\\"baz'\"" |
There was a problem hiding this comment.
??? Do you have a question about this?
Signed-off-by: Jan Dubois <jan.dubois@suse.com>
See rancher-sandbox#5104 So we don't need to check the output of `rdctl api /settings` for it anymore. Signed-off-by: Jan Dubois <jan.dubois@suse.com>
IsaSih
requested changes
Jul 20, 2023
IsaSih
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.