Bump to https-proxy-agent 7.0.1 and update client code. #5214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Promislow <epromislow@suse.com>
rak-phillip
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5057
See also #4622 to see how the client code was changed going from 5.x to 6.0
6.0 was a breaking change, so we needed to update the client code. There hasn't been a breaking
change since then, and no client change appears necessary.
References:
5009 - how the 6.x version broke proxies
above introduced by Bump https-proxy-agent from 5.0.1 to 6.1.0 #4622
Upstream issue: Issue with header parse buffer logic TooTallNate/proxy-agents#207
<HTML><HEAD>…If someone with all the required network pieces could test this change so it breaks with the 1.9.0 release but works here, that would be great. FWICT the failure happened at startup while collecting certs.