[v2.9] Add "registryconfig-auth-" secrets to backup rules #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport v2.8-Next2 release/v4.0 |
mallardduck
changed the title
|
/backport v2.7-Next1 release/v3.0 |
alexandreLamarre
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR helps address the issue here: rancher/rancher#44033
The fix being done here versus where the original issue planned means we can deliver a partial fix rather easily here. And a more complete fix that could take more time can still be done later.
This fix relies on a different BRO resourceset rule than they planned on using. And our fix will only catch secrets made via Rancher with the default generated name prefix
registryconfig-auth-but not any secrets that the user creates outside of the "Cluster Creation UI" that may have different names.As this is a chart change it needs to be:
rancher/chartsrelease to match.It should also be back ported to 2.8 at the very least. Unlikely worth the effort to do that for 2.7 too.