Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GHA comment commands for porting #481

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

mallardduck
Copy link
Member

These GHA commands allow us to create comments like:

  • /backport release/4.0
  • /forwardport release/5.0
  • /backport v2.8.next1

Where when it's on a PR you should provide a specific branch on this repo and it will create a new PR based on it targeting the new branch. And when it's an Issue it will create a new issue to track porting it to the tagged rancher release name.

@mallardduck
Copy link
Member Author

Would be neat to review and merge this one first - then test it on #480 since I want to see that backported to 2.8 too.

Copy link
Collaborator

@ericpromislow ericpromislow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots going on here, but these files are almost identical to the ones in dashboard, so approving

@mallardduck mallardduck merged commit 30f6081 into rancher:release/v5.0 Jul 9, 2024
3 checks passed
@mallardduck
Copy link
Member Author

Looks like I need to follow up here for 2 issues:

  • Both workflows triggering resulting in 2 comments.
  • Workflow cannot parse branches with / in the correctly;
    • errors about release/v4.0 being parsed as releasev4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants