Download icons locally when running make charts #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diogoasouza
force-pushed
the
add-make-icon
branch
from
3af1f55 to
abbc0e0
Compare
rohitsakala
requested changes
Jan 11, 2024
There was a problem hiding this comment.
I have two concerns here
- This kind of logic will make the Chart.yaml inside chart tar differ from index.yaml. This voilates one of the checkpoints we have when we release a chart.
- We are modifying metadata of something that is already in released and in use for old versions.
Alternate Solution
- Can we consider a make target which blocks a user in adding a version of a chart that has chart.icon not pointing to file://.assets/logos/{image}.png
diogoasouza
force-pushed
the
add-make-icon
branch
from
abbc0e0 to
621d900
Compare
pkg/icons/icons.go
Outdated
| for name := range helmIndexFile.Entries { | ||
| latestEntryVersion := helmIndexFile.Entries[name][0] | ||
| latestIconName := name | ||
| if strings.Contains(name, "-crd") { |
There was a problem hiding this comment.
// We don't add any icons for "CRD" because they are not displayed as installable charts
pkg/icons/icons.go
Outdated
| return nil | ||
| } | ||
|
|
||
| func download(rootFs billy.Filesystem, url, path string) (string, error) { |
There was a problem hiding this comment.
It is not needed for rancher/charts
But for rancher/partner-charts if possible and if we are the ones who will implement this same strategy.
I would consider a for loop with go functions for the download execution.
120+ rancher partner charts
diogoasouza
force-pushed
the
add-make-icon
branch
3 times, most recently
from
270b6ee to
de302cd
Compare
diogoasouza
changed the title
rohitsakala
approved these changes
Jan 13, 2024
rohitsakala
approved these changes
Jan 13, 2024
lucasmlp
suggested changes
Jan 15, 2024
diogoasouza
force-pushed
the
add-make-icon
branch
3 times, most recently
from
d6192b5 to
a19a0b0
Compare
rohitsakala
requested changes
Jan 16, 2024
diogoasouza
force-pushed
the
add-make-icon
branch
from
a19a0b0 to
342dd95
Compare
rohitsakala
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the
make chartscommand, it will check if the icon is pointing to a HTTP URL, and if so, download it and change theChart.yamlto generated from the packages folder to point to it