-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GHA migration: secrets check #365
GHA migration: secrets check #365
Conversation
f77c30f
to
7d7f4e8
Compare
Thanks for the review @andreas-kupries . I checked with @Anarkis and the error is expected because of the run on a different repo. Once merged we can check that the secrets are ok. |
For my migration I actually did a test PR on a non-forked branch to check that the creds worked, and, of course the actions after also. For the FOSSA this might not be as important, as it is a code check, and not pushing anything. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Secrets are working fine 👍 |
This PR adds the steps that will use the migrated secrets, and a
release.yml
workflow that will be used for the releases.The FOSSA secret with the API key is used during the CI workflow.
The Docker Hub username and password will be used during the release. At the moment we are just going to login to see that they are working fine.
This PR is needed because the branched of the CLI repo are protected, and we need PRs for them.
This is a first step "soft" PR used for the migration with no side-effects.