Rotate kubeconfig before it expires #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ttreptow thanks for the PR, can you please fix the linter errors, before we take a closer look at it? Thanks! |
ttreptow
force-pushed
the
fix-kubeconfig-rotate
branch
from
74bf0d4 to
d835bb9
Compare
|
Updated to fix lints |
alexander-demicev
previously approved these changes
Jan 7, 2025
controlplane/internal/controllers/rke2controlplane_controller.go
Outdated
Show resolved
Hide resolved
ttreptow
force-pushed
the
fix-kubeconfig-rotate
branch
from
d9fc050 to
891993a
Compare
alexander-demicev
added
kind/bug
Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
alexander-demicev
force-pushed
the
fix-kubeconfig-rotate
branch
from
891993a to
694ecd1
Compare
alexander-demicev
added
kind/feature
alexander-demicev
approved these changes
Jan 8, 2025
salasberryfin
approved these changes
Jan 8, 2025
salasberryfin
approved these changes
Jan 8, 2025
yiannistri
approved these changes
Jan 8, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Recreates the kubeconfig after half of the expiration period (1 year, renews 6 months). See similar code in kubeadm control plane here
Which issue(s) this PR fixes
Special notes for your reviewer:
Checklist: