[WIP] Add kubeconfig certificate rotation tests #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
yiannistri
approved these changes
Jan 9, 2025
anmazzotti
approved these changes
Jan 9, 2025
alexander-demicev
requested changes
Jan 9, 2025
There was a problem hiding this comment.
adding "requesting changes" so the PR doesn't get merged and close the issue. @furkatgofurov7 would you be able to verify that rotating kubeconfig causes an update for machines? Maybe trigger it somehow manually from code, I don't have ideas how to verify it in other ways at the moment
furkatgofurov7
changed the title
Comment on lines
+284
to
+287
| _, err = r.reconcileKubeconfig(ctx, clusterName, endpoint, rcp) | ||
| Expect(err).ToNot(HaveOccurred()) | ||
|
|
||
| Expect(testEnv.Get(ctx, client.ObjectKey{Namespace: ns.Name, Name: secret.Name}, secret)).To(Succeed()) |
There was a problem hiding this comment.
Can we also check that the kubeconfig secret is actually rotated? It seems to me that the current validation equals to “no rotation” test case: https://github.com/rancher/cluster-api-provider-rke2/pull/550/files#diff-cd4559684c03b3b2a238ed4f8c142bb867312c79174f5a6474b157ac7849a737R312-R316
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds new test cases for kubeconfig certificate automatic rotation implementation in #521
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #520
Special notes for your reviewer:
Checklist: