Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Burger Menu: Cluster List: Placement of pin cluster is incorrect, causes scroll bar #11809

Closed
richard-cox opened this issue Sep 4, 2024 · 5 comments · Fixed by #12591
Closed
Assignees
Labels
kind/bug QA/manual-test Indicates issue requires manually testing status/backport-candidate
Milestone

Comments

@richard-cox
Copy link
Member

Setup

  • Rancher version: dev of 2.10.0

Describe the bug

  • hovering over a cluster in the burger menu should show an icon on right of row to pin the cluster to the top of the list
  • when there are too many clusters a vertical scroll bar is shown
  • in vue3 world hovering over a cluster shows the pin icon underneath the vertical scroll bar and prompts a horizontal scroll bar to be shown

To Reproduce

  • add 4 or so clusters (can be imported/custom)
  • reduce height of window such that a scroll bar appears
  • hover over the local text

Result
image

Expected Result

  • No horizontal scroll bar
  • Pin visible
  • This is how it previously looked (not great, but better than current)
    • image

Screenshots

Additional context

  • the vertical scroll bar is quite common in my setup
    • legacy enabled, multiple global apps / extensions. chuck in dev tools at bottom and it's always shown
@richard-cox richard-cox added kind/bug area/vue3 Bugs and technical debts as outcome to the Vue3 migration labels Sep 4, 2024
@richard-cox richard-cox added this to the v2.10.0 milestone Sep 4, 2024
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Sep 4, 2024
@rancher rancher deleted a comment Sep 4, 2024
@richard-cox richard-cox changed the title Burger Menu: Cluster List: Placement of pin cluster is incorrect, causes scroll bar Vue3: Burger Menu: Cluster List: Placement of pin cluster is incorrect, causes scroll bar Sep 4, 2024
@momesgin
Copy link
Member

Seems we have the scrollbar issue in vue2 as well
Image

@momesgin momesgin assigned eva-vashkevich and unassigned momesgin Sep 11, 2024
@richard-cox
Copy link
Member Author

richard-cox commented Sep 12, 2024

Interesting, i couldn't reproduce with release-2.9. Looking at the screenshots the horizontal scroll bar is important

@richard-cox richard-cox removed the area/vue3 Bugs and technical debts as outcome to the Vue3 migration label Sep 12, 2024
@richard-cox richard-cox changed the title Vue3: Burger Menu: Cluster List: Placement of pin cluster is incorrect, causes scroll bar Burger Menu: Cluster List: Placement of pin cluster is incorrect, causes scroll bar Sep 12, 2024
@gaktive gaktive modified the milestones: v2.10.0, v2.11.0 Oct 29, 2024
@nwmac nwmac modified the milestones: v2.12.0, v2.11.0 Nov 1, 2024
@gaktive
Copy link
Member

gaktive commented Nov 1, 2024

I'll hold on filing a backport for now until we know what the solution is and if it's a quick one. 2.10.x seems reasonable but 2.9.x with its Vue2 may be a stretch.

@eva-vashkevich eva-vashkevich added QA/manual-test Indicates issue requires manually testing and removed QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this labels Nov 12, 2024
@izaac izaac self-assigned this Nov 27, 2024
@izaac
Copy link
Contributor

izaac commented Dec 13, 2024

Rancher version: v2.11-7839201dc49c3cbd138b0bb99028c5705825d699-head
UI version: release-2.10 d5b785b

I wasn't able to reproduce. I've changed the size, and smaller than a phone screen and the horizontal bar didn't appear in the menu.

In the screenshot below this is the most I could resize the browser horizontally, the scrollbar there is expected as there was 10 clusters in the setup.

Image

@izaac izaac closed this as completed Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug QA/manual-test Indicates issue requires manually testing status/backport-candidate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants