Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure we look at the correct resource type when enabling Feature Flag edits #11169

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Ensure we look at the correct resource type when enabling Feature Flag edits #11169

merged 1 commit into from
Jun 4, 2024

Conversation

richard-cox
Copy link
Member

Summary

Ensure we look at the correct resource type when enabling Feature Flag edits

Occurred changes and/or fixed issues

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@richard-cox richard-cox added this to the v2.7.patch1 milestone Jun 4, 2024
@richard-cox richard-cox requested a review from nwmac June 4, 2024 08:43
@richard-cox richard-cox self-assigned this Jun 4, 2024
nwmac
nwmac approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richard-cox richard-cox merged commit 75da7d0 into rancher:release-2.7.patch1 Jun 4, 2024
8 checks passed
@richard-cox richard-cox deleted the ff-perm-fix branch June 4, 2024 10:24
@rak-phillip rak-phillip mentioned this pull request Jun 17, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwmac nwmac nwmac approved these changes

Assignees

@richard-cox richard-cox

Labels
None yet
Projects
None yet
Milestone
v2.7.14
Development

Successfully merging this pull request may close these issues.
2 participants
@richard-cox @nwmac