Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enableRowActions looking at the wrong schema #9759

Merged
1 commit merged into from Sep 27, 2023
Merged

enableRowActions looking at the wrong schema #9759

1 commit merged into from Sep 27, 2023

Conversation

ghost
Copy link

@ghost ghost commented Sep 22, 2023

Summary

Fixes rancherlabs/ranchersecurity/1205
It looks like the code that should've enabled the row actions on the features list was looking at the setting schema instead of the feature schema in the management store like it should've been.

Occurred changes and/or fixed issues

Just changed the type we're looking for on the features list to enable row actions on the features list.

Technical notes summary

When a user has minimal permissions to change features (presumably uncommon, the user will usually be an admin of some type), it's critical that we validate permissions against the correct schema until a more robust permission checking method can be implemented.

Areas or cases that should be tested

Should be able to just test the rowActions on the table at /c/_/settings/management.cattle.io.feature to make sure they appear correctly when the user has the permissions listed under https://github.com/rancherlabs/rancher-security/issues/1205

Areas which could experience regressions

This is a pretty targeted change, no regressions expected.

@ghost ghost requested review from Shavindra and mantis-toboggan-md September 22, 2023 14:17
@github-actions github-actions bot assigned ghost Sep 22, 2023
@ghost ghost merged commit 8108a49 into rancher:master Sep 27, 2023
8 checks passed
yonasberhe23 pushed a commit to yonasberhe23/dashboard that referenced this pull request Dec 20, 2023
yonasberhe23 pushed a commit to yonasberhe23/dashboard that referenced this pull request Jan 26, 2024
@gaktive
Copy link
Member

gaktive commented Jun 3, 2024

/backport v2.7.patch1

@gaktive
Copy link
Member

gaktive commented Jun 3, 2024

/backport v2.8.patch1

richard-cox pushed a commit to richard-cox/dashboard that referenced this pull request Jun 4, 2024
rak-phillip pushed a commit to rak-phillip/dashboard that referenced this pull request Jun 17, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants