Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent side nav auto-collapse #6657

Closed
wants to merge 1 commit into from

Conversation

catherineluse
Copy link
Contributor

@catherineluse catherineluse commented Aug 15, 2022

This PR fixes #6658 and partly addresses #4431 (comment)

Changes in this PR:

  • Side nav in Cluster Explorer no longer auto-collapses as you navigate
  • You can now have more than one group expanded in the side nav

Reasons for the change:

Screenshot of multiple groups expanded:

Screen Shot 2022-08-15 at 2 15 08 PM

To test this PR, I went to Cluster Explorer and:

  • Confirmed that when a nav group is clicked, it expands
  • When an expanded group is clicked, it collapses
  • When collapsing a group that is actively selected, it is still marked as active/highlighted
  • Changing between different nav items does not auto-collapse nav items

Note: I think the auto-collapse may have originally been intended to prevent an issue with the nav becoming too long for the page, but we no longer have this problem due to the scroll bar on the nav section

@nwmac
Copy link
Member

nwmac commented Aug 16, 2022

@catherineluse The auto-collapse was added because the feedback from users was that the navigation was overwhelming. I think we need to discuss this change with @kwwii

@richard-cox
Copy link
Member

I think when we didn't auto-collapse menu groups there was some weirdness when the resource was starred, think both starred and the menu group would open up. Worth testing for regressions.

@richard-cox richard-cox added this to the v2.7.0 milestone Aug 16, 2022
@catherineluse
Copy link
Contributor Author

Related to SURE-3658

@catherineluse catherineluse marked this pull request as draft August 22, 2022 16:10
@nwmac nwmac modified the milestones: v2.7.0, v2.7.1 Sep 27, 2022
@zube zube bot added [zube]: Done and removed [zube]: Review labels Dec 1, 2022
@zube zube bot removed the [zube]: Done label Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow user to configure side nav auto-collapse
3 participants