Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nginx 1.11.3 | Resolve merge conflicts by moving dependency updates to separate commit #146

Merged
merged 82 commits into from
Oct 15, 2024

Conversation

chiukapoor
Copy link

Updates

  • Add nginx 1.11.3
  • The ingress-nginx workflow is failing due to merge conflicts in go.work.sum (reference), primarily caused by frequent updates to the file. This leads to recurring automation failures. To mitigate this, we propose removing the dependency updates from commit 0ad500f4 and placing them in a separate commit go generate , similar to the vendor update process used in rancher/kubernetes. This will allow the automation to run go work sync and reduce merge conflicts in future.

Co-authored-by: Ricardo Katz <ricardo.katz@gmail.com>
…ernetes#11834)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…#11837)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…#11839)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…netes#11840)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ricardo Katz <ricardo.katz@gmail.com>
…1881)

Signed-off-by: Seonghyeon Cho <seonghyeoncho96@gmail.com>
Co-authored-by: Seonghyeon Cho <seonghyeoncho96@gmail.com>
…ernetes#11868)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
)

Signed-off-by: Seonghyeon Cho <seonghyeoncho96@gmail.com>
Co-authored-by: Seonghyeon Cho <seonghyeoncho96@gmail.com>
Signed-off-by: James Strong <strong.james.e@gmail.com>
Co-authored-by: James Strong <strong.james.e@gmail.com>
…#11889)

Co-authored-by: Marco Ebert <marco_ebert@icloud.com>
…ernetes#11908)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…1909)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…kubernetes#11913)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Marco Ebert <marco_ebert@icloud.com>
Co-authored-by: Marco Ebert <marco_ebert@icloud.com>
Co-authored-by: Marco Ebert <marco_ebert@icloud.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…#11930)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Nathan Baulch <nathan.baulch@gmail.com>
Co-authored-by: Marco Ebert <marco_ebert@icloud.com>
Co-authored-by: longwuyuan <longwuyuan@gmail.com>
Co-authored-by: Damien Mehala <damien.mehala+github@gmail.com>
… all group (kubernetes#11957)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…2087)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: James Strong <strong.james.e@gmail.com>
Co-authored-by: Marco Ebert <marco_ebert@icloud.com>
Co-authored-by: Marco Ebert <marco_ebert@icloud.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Marco Ebert <marco_ebert@icloud.com>
Co-authored-by: Marco Ebert <marco_ebert@icloud.com>
Co-authored-by: Marco Ebert <marco_ebert@icloud.com>
Co-authored-by: Marco Ebert <marco_ebert@icloud.com>
Co-authored-by: Marco Ebert <marco_ebert@icloud.com>
Co-authored-by: Marco Ebert <marco_ebert@icloud.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* refactor rancher build process due to upstream changes
* Remove drone
`go install ginkgo` followed by `which ginkgo` is newly added in the upstream repo.
This is making the drone build fail for arm64 arch. The ginkgo library
gets installed under $GOPATH/bin/linux_arm64 dir. This is unlike amd64 images
which typically install go libraries under $GOPATH/bin. Since the previously mentioned
dir is not in PATH, the command `which ginkgo` fails. I've added this location to PATH
to fix the build failure. See upstream PRs linked below for more info:
kubernetes#8566
kubernetes#8569
@chiukapoor chiukapoor requested a review from kinarashah October 15, 2024 17:32
@kinarashah kinarashah merged commit d4f428d into rancher:nginx-1.11.x-fix Oct 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants