Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Add Rancher Turtles uninstallation notes #62

Merged
merged 3 commits into from
Mar 13, 2024

Conversation

furkatgofurov7
Copy link
Contributor

@furkatgofurov7 furkatgofurov7 commented Mar 11, 2024

Related to: rancher/turtles#425

Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
@furkatgofurov7
Copy link
Contributor Author

This needs to be on hold until rancher/turtles#425 is merged

@furkatgofurov7
Copy link
Contributor Author

@richardcase @Danil-Grigorev thanks folks for reviews, updated now.

salasberryfin
salasberryfin previously approved these changes Mar 12, 2024
@furkatgofurov7
Copy link
Contributor Author

furkatgofurov7 commented Mar 12, 2024

@richardcase @Danil-Grigorev after discussing this with @salasberryfin and giving it another thought, maybe we need to extend the current PR a bit. In reality, user can uninstall extenstion in 2 ways:

  1. Extension installed via Rancher Manager (local cluster=>adding repo=>installing chart). By default, cleanup is enabled and when user uninstalls the chart from Rancher Manager, it should be uninstalled (covered in this PR)
  2. Extension installed via helm command. By default, cleanup is enabled and when user uninstalls the chart using helm uninstall, it should be uninstalled (not covered)

Does it make sense to note both options in this PR, WDYT?

@richardcase
Copy link
Contributor

Does it make sense to note both options in this PR, WDYT?

I think we should cover both options.

Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
@furkatgofurov7
Copy link
Contributor Author

furkatgofurov7 commented Mar 12, 2024

@richardcase @Danil-Grigorev after discussing this with @salasberryfin and giving it another thought, maybe we need to extend the current PR a bit. In reality, user can uninstall extenstion in 2 ways:

  1. Extension installed via Rancher Manager (local cluster=>adding repo=>installing chart). By default, cleanup is enabled and when user uninstalls the chart from Rancher Manager, it should be uninstalled (covered in this PR)
  2. Extension installed via helm command. By default, cleanup is enabled and when user uninstalls the chart using helm uninstall, it should be uninstalled (not covered)

Does it make sense to note both options in this PR, WDYT?

This is how it looks after recent changes:

image

@furkatgofurov7
Copy link
Contributor Author

This needs to be on hold until rancher-sandbox/rancher-turtles#425 is merged

425 is merged, and this should be unblocked now

@furkatgofurov7 furkatgofurov7 self-assigned this Mar 12, 2024
salasberryfin
salasberryfin previously approved these changes Mar 12, 2024
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
@furkatgofurov7
Copy link
Contributor Author

Pushed 9c59f83 to update values.md with new options.

@furkatgofurov7
Copy link
Contributor Author

furkatgofurov7 commented Mar 12, 2024

@richardcase @salasberryfin updated now, PTAL

@furkatgofurov7 furkatgofurov7 merged commit bce5329 into rancher:main Mar 13, 2024
2 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants