✨ Add post-delete helm hook for RT extension deletion process #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
furkatgofurov7
changed the title
|
Looks good to me. Just left a comment on the |
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
Danil-Grigorev
approved these changes
Mar 12, 2024
richardcase
approved these changes
Mar 12, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds a post-delete hook to the helm chart for taking care of Rancher Turtles extension deletion properly
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #409
Special notes for your reviewer:
Documentation PR: rancher/turtles-docs#62
Checklist: