Add v1->v3 cluster migration #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-demicev
force-pushed
the
v1v3clustermigration
branch
4 times, most recently
from
8c6d64a
to
0f56eb4
Compare
salasberryfin
force-pushed
the
v1v3clustermigration
branch
from
dc81463
to
2db104d
Compare
|
Thanks @alexander-demicev, LGTM. I pushed some minor changes to fix CI checks and I'm fixing E2E tests locally and will be pushing an update too. |
salasberryfin
force-pushed
the
v1v3clustermigration
branch
2 times, most recently
from
8284d36
to
f6374f2
Compare
|
@alexander-demicev is this a duplicate of #576 ? |
salasberryfin
force-pushed
the
v1v3clustermigration
branch
from
f6374f2
to
298ab0b
Compare
|
Hey @furkatgofurov7, #576 implements the approach presented by @Danil-Grigorev, which will be considered the primary migration method. The changes proposed in this PR will allow us to also support manual migration of clusters and it will also help with avoiding breaking clusters when users do not follow the proper migration procedure, i.e. prevent from creating duplicate resources to represent the same CAPI cluster. |
salasberryfin
force-pushed
the
v1v3clustermigration
branch
3 times, most recently
from
262b3b2
to
13fecc9
Compare
|
Thanks for the review @Danil-Grigorev. Only E2E is pending for this to be ready to be merged. |
4 tasks
salasberryfin
force-pushed
the
v1v3clustermigration
branch
2 times, most recently
from
6f5d061
to
ea73ccc
Compare
4 tasks
Danil-Grigorev
approved these changes
Jun 27, 2024
Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
Signed-off-by: Carlos Salas <carlos.salas@suse.com>
salasberryfin
force-pushed
the
v1v3clustermigration
branch
from
ea73ccc
to
a718f20
Compare
Danil-Grigorev
approved these changes
Jun 28, 2024
furkatgofurov7
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR allows migrating from V1->V3 cluster without reimporting the clusters. Rancher already creates a V3 cluster for every V1 cluster. V3 cluster controller will check that V1 cluster includes a migrated annotation or exists at all for a given v3 cluster if the annotation is present, the reconciliation will continue as expected.
Users are required to set proper labels on the existing V3 cluster before migrating, this will be described in the ADR and rancher turtles docs.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: