Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: check migration to v3 controller #585

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

salasberryfin
Copy link
Contributor

What this PR does / why we need it:

We decided to split into a separate PR the E2E tests added to validate v1 to v3 controller migration. The changes to the controller can be found in #575. This PR only affects E2E scenarios.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@furkatgofurov7
Copy link
Contributor

@salasberryfin can we rebase this PR?

@Danil-Grigorev
Copy link
Contributor

@salasberryfin Can you please rebase this PR?

@salasberryfin salasberryfin force-pushed the test-migration-v3-e2e branch 2 times, most recently from 19c32e2 to a5dc55d Compare July 15, 2024 08:50
@furkatgofurov7
Copy link
Contributor

Does this need a rebase again?

@salasberryfin
Copy link
Contributor Author

This was rebased today but it is still failing when trying to connect to the downstream cluster after migration using kubeconfig. Still figuring out the reason behind this.

Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
Signed-off-by: Carlos Salas <carlos.salas@suse.com>
@Danil-Grigorev
Copy link
Contributor

@salasberryfin The problem you are facing might be fixed by 7653a81#diff-7be87c7e06c4b33e0c43cce272e500934fca8631072faf36237af336d4c1c562R185-R190

Signed-off-by: Carlos Salas <carlos.salas@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants